feat: Experimental encrypted state feature flag with CI support #5537
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylendog
commented
Aug 14, 2025
Comment on lines
+1166
to
+1167
| #[cfg(feature = "experimental-encrypted-state-events")] | ||
| encrypt_state_events: false, |
There was a problem hiding this comment.
This is the change to the test I mentioned in the PR descrption - didn't catch it erroring prior to merging #5511 since there was no CI (sorry 😬)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5537 +/- ##
==========================================
- Coverage 88.57% 88.56% -0.01%
==========================================
Files 340 340
Lines 93688 93690 +2
Branches 93688 93690 +2
==========================================
- Hits 82982 82980 -2
- Misses 6573 6577 +4
Partials 4133 4133 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5537 will not alter performanceComparing Summary
|
* Adds a `experimental-encrypted-state-events` feature flag across the SDK. * Introduces a feature set into xtask to ensure feature-gated tests are run during CI. * Introduces a new matrix entry into the Ubuntu CI. * Minor fix to a test that would otherwise fail with the newly introduced CI.
kaylendog
force-pushed
the
kaylendog/msc3414/xtask
branch
from
3ba70c8 to
c1a0f2e
Compare
|
Looks like another flaky |
Indeed, tracked at #5068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some non-domain-specific changes across multiple crates that are required for proper testing of features implemented for #5397.
experimental-encrypted-state-eventsfeature flag across the SDK.